Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links not showing up properly #32

Open
andresgnlez opened this issue Jun 22, 2016 · 5 comments
Open

links not showing up properly #32

andresgnlez opened this issue Jun 22, 2016 · 5 comments
Assignees

Comments

@andresgnlez
Copy link
Contributor

Hi @shanikadhettige,

I just notice links in the website are not showing up properly. That's becuase their markup.

I just fix one of them as example, you can see it here: Vizzuality/community-mapping@cd44c3e

I attach you a guide about how to write markdown to make things easier: https://help.github.com/articles/basic-writing-and-formatting-syntax/#links

Let me know if you have any question.

@shanikadhettige
Copy link
Collaborator

Noted, will search and change in tomorrow's edits.

@shanikadhettige
Copy link
Collaborator

Let me know if they're working after you merge the new pull requests from deploy. If fixed, please close. Thank you for catching this!

@andresgnlez
Copy link
Contributor Author

I just deployed new changes, links are working fine now!

Just one thing: Vizzuality/community-mapping@179a79d

Don't forget to add the protocol (http or https) to links, if not the site won't recognize them as links. I just fixed these ones. I haven't found more.

I think this issue is done, so.. Closing..!

@andresgnlez
Copy link
Contributor Author

I just notice not all links are rendering properly. This is because some of them are written in HTML elements... So, to make things easier, from now on it would be nice write links with HTML:

<a href="http://my-url" target="_blank">link_name</a>

Where my-url is the URL you are pointing, link_name is the visual name of the link and the attribute target="_blank" is used to open links in new tabs instead the current tab and it's optional.

I have changed the current links to this way, you can check them as example.

Sorry for any inconvenience!

@andresgnlez andresgnlez reopened this Jun 24, 2016
@shanikadhettige
Copy link
Collaborator

I searched the whole file for href yesterday. Either I missed one or it is changing automatically. It isn't ideal to do it all again if it was just one.
If it might be changing automatically please let me know.

On Jun 24, 2016, at 06:31, Andrés González [email protected] wrote:

I just notice not all links are rendering properly. This is because some of them are written in HTML elements... So, to make things easier, from now on it would be nice write links with HTML:

link_name

Where my-url is the URL you are pointing, link_name is the visual name of the link and the attribute target="_blank" is used to open links in new tabs instead the current tab and it's optional.

I have changed the current links to this way, you can check them as example.

Sorry for any inconvenience!


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants