Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galax Feature Parity #298

Open
51 of 86 tasks
nstarman opened this issue May 6, 2024 · 3 comments
Open
51 of 86 tasks

Galax Feature Parity #298

nstarman opened this issue May 6, 2024 · 3 comments
Milestone

Comments

@nstarman
Copy link
Contributor

nstarman commented May 6, 2024

.coordinates

  • cartesian_to_poincare_polar (Polar Poincare Vector coordinax#136)
  • make_greatcircle_cls (will be done in coordinax)
  • pole_from_endpoints (will be done in coordinax)
  • reflex_correct
  • transform_pm_cov (will be done in coordinax)
  • vgsr_to_vhel
  • vhel_to_vgsr

Coordinate Frames:

  • Frame Classes require the Operator framework to be worked on further!

.integrate

Only need the Diffrax integrator. It would be good to add the others, for reproducibility.

  • DOPRI853Integrator
  • LeapfrogIntegrator
  • RK5Integrator
  • Ruth4Integrator

.potential

Gravitational Potentials

  • base class
  • composite classes

Specific Gravitational Potentials:

Methods on Potentials:

  • acceleration
  • as_interop (implement as connection to existing I/O)
  • circular_velocity (feat: circular velocity #417)
  • density
  • energy (done as potential_energy)
  • gradient
  • hessian
  • integrate_orbit (done as evaluate_orbit)
  • mass_enclosed (this will be a separate function since it assumes incorrect things about potentials)
  • plotting (feat: plotting #97)
    • plot_contours
    • plot_density_contours
    • plot_rotation_curve
  • replicate (use dataclasses.replace)
  • replace_units (IDK if this will be supported as it's used in gala for internally stripping units, which galax doesn't need to do)
  • save
  • to_latex
  • to_sympy
  • total_energy
  • value (done as potential_energy and __call__)

Helper Functions:

  • from_equation
  • save / load

Reference Frames

  • StaticFrame
  • ConstantRotatingFrame

.dynamics

.units

  • Everything. See unxt package.
@nstarman nstarman added this to the v0.1 milestone May 6, 2024
@nstarman nstarman pinned this issue May 6, 2024
@nstarman
Copy link
Contributor Author

nstarman commented May 11, 2024

@adrn @jnibauer What do you think should be our v0.1 goals? I think all the potentials (and methods like circular velocity) + StreamDFs + reflex_correct. We are relatively close. We also need to standardize the parameter names and smooth the time API.

@nstarman nstarman modified the milestones: v0.1, future May 11, 2024
@adrn
Copy link
Collaborator

adrn commented Aug 24, 2024

I think potentials, circular_velocity/mass_enclosed, streams, and documentation/tutorials!

@nstarman
Copy link
Contributor Author

IMO We should also add back in some methods, like integrate_orbit, but @deprecated so that users can seamlessly transition their code from gala to galax, then update to the new (and not deprecated) API.
E.g. #419 andMockstreamGenerator, but which point users to #193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants