Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line number to goto #464

Open
kevinkehl opened this issue Oct 25, 2017 · 2 comments
Open

Add line number to goto #464

kevinkehl opened this issue Oct 25, 2017 · 2 comments

Comments

@kevinkehl
Copy link
Contributor

It could be useful when navigating large files with lots of exports (read: libraries) to provide a line number for the export as well as file path for the goto function. This might be an editor-breaking change, since the goto response is currently just a string, not an object. We could add another top-level field to avoid the breaking change, but that wouldn't be ideal. Thoughts? I'd be happy to work on this if it sounds useful.

@lencioni
Copy link
Collaborator

Another possibility would be adding a flag of some sort to specify the format of goto. e.g. goto --format=json

@trotzig
Copy link
Collaborator

trotzig commented Oct 26, 2017

I like this idea, and I wonder if we could make a cheap test in one of the clients before we try it out? Clients now what variables they go to, and they can make a best-attempt at finding the export in the goto file. If it feels good, we can make it part of the daemon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants