Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable per-package installations #491

Open
lencioni opened this issue Mar 26, 2018 · 1 comment
Open

Enable per-package installations #491

lencioni opened this issue Mar 26, 2018 · 1 comment

Comments

@lencioni
Copy link
Collaborator

It would be nice if teams could specify a version of import-js they depend on in their package.json, and then have that version be what the editor uses when interacting in that project. This would couple well with #490, where there might be other plugins that are relevant for that project.

I think the trick here would be sorting out how the daemon works and how one might be able to run multiple daemons simultaneously.

@trotzig
Copy link
Collaborator

trotzig commented Mar 28, 2018

The daemon is run by invoking importjs start. If importjs is installed locally, we'd have to figure out a way to run it from within the local node_modules folder instead of invoking that command directly. Something like

$(npm bin)/importjs start

I guess we need to build into the editor plugins/clients some way of detecting the importjs binary to use. Something like:

if (file_exists($cwd/node_modules/.bin/importjs)) then
  $cwd/node_modules/.bin/importjs start
else 
  importjs start
fi

where $cwd is the project root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants