Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playground PR preview #950

Closed
1 task done
carstingaxion opened this issue Oct 14, 2024 · 5 comments · Fixed by #951
Closed
1 task done

Fix Playground PR preview #950

carstingaxion opened this issue Oct 14, 2024 · 5 comments · Fixed by #951
Labels
bug Something isn't working

Comments

@carstingaxion
Copy link
Collaborator

carstingaxion commented Oct 14, 2024

Describe the bug

The last recent PRs didn't had working preview Playgrounds.

  1. The first reason was easy found and fixed fast: I needed to update a GitHub token, that I renewed meanwhile. ✔️
  2. Now things got strange:
    1. The normal preview link like this, fails
    2. It still shows, that the zip file is loaded from the artifact and installed
    3. But it won't activate automatically
    4. Even I can do that manually without any problems

Steps to Reproduce

..

Screenshots, screen recording, code snippet

image

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added the bug Something isn't working label Oct 14, 2024
@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Oct 14, 2024

  • The "pluginZipFile" option of the "installPlugin" step is deprecated. Use "pluginData" instead.
  • The "zipPath" option of the unzip() Blueprint step is deprecated and will be removed. Use "zipFile" instead.
  • Invalid blueprint: must be object at /steps/6/zipFile

@carstingaxion
Copy link
Collaborator Author

Error: Error when executing the blueprint step #7 ({"step":"installPlugin","pluginData":{"resource":"vfs","path":"/wordpress/pr/gatherpress.zip"},"options":{"activate":true}}) : 
Plugin /wordpress/wp-content/plugins/gatherpress could not be activated – WordPress exited with no error. Sometimes, when $_SERVER or site options are not configured correctly, WordPress exits early with a 301 redirect. Inspect the "debug" logs in the console for more details

@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Oct 14, 2024

Not starting a multisite fixes the issue

Using the Preview link from #949 and just removing:

    {
      "step": "enableMultisite"
    },

... everything is fine.

@carstingaxion
Copy link
Collaborator Author

Moving the enableMultisite step to the end of the blueprint, after the plugin is activated, works, too.

@carstingaxion
Copy link
Collaborator Author

Superstrange.

carstingaxion added a commit to carstingaxion/gatherpress that referenced this issue Oct 14, 2024
@carstingaxion carstingaxion mentioned this issue Oct 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant