Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatNumberPipe bug for values greater than 1M #63

Open
juandjara opened this issue Mar 23, 2018 · 0 comments
Open

formatNumberPipe bug for values greater than 1M #63

juandjara opened this issue Mar 23, 2018 · 0 comments
Labels
bug

Comments

@juandjara
Copy link
Member

juandjara commented Mar 23, 2018 •
edited
Loading

The Angular pipe FormatNumberPipe will have an odd behavior for values greater or equal than 1 Million when the option compact is set to false.

This is because the number will have more parts to split, 4 or more, instead of the 3 parts the current code thinks it will have. To solve this we could use an iterative approach or force the option compact to be true when the value is greater than 1M.
@juandjara juandjara added the bug label Mar 23, 2018
@juandjara juandjara changed the title Bug en formatNumberPipe para valores >= 1M con compact = false Bug en formatNumberPipe Mar 23, 2018
@juandjara juandjara changed the title Bug en formatNumberPipe formatNumberPipe bug for values greater than 1M Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juandjara