diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp index 88709bb261874..4989ddc3ec94f 100644 --- a/mlir/lib/Transforms/Utils/DialectConversion.cpp +++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp @@ -965,14 +965,14 @@ class ModifyOperationRewrite : public OperationRewrite { ModifyOperationRewrite(ConversionPatternRewriterImpl &rewriterImpl, Operation *op) : OperationRewrite(Kind::ModifyOperation, rewriterImpl, op), - loc(op->getLoc()), attrs(op->getAttrDictionary()), + name(op->getName()), loc(op->getLoc()), attrs(op->getAttrDictionary()), operands(op->operand_begin(), op->operand_end()), successors(op->successor_begin(), op->successor_end()) { if (OpaqueProperties prop = op->getPropertiesStorage()) { // Make a copy of the properties. propertiesStorage = operator new(op->getPropertiesStorageSize()); OpaqueProperties propCopy(propertiesStorage); - op->getName().initOpProperties(propCopy, /*init=*/prop); + name.initOpProperties(propCopy, /*init=*/prop); } } @@ -988,7 +988,9 @@ class ModifyOperationRewrite : public OperationRewrite { void commit() override { if (propertiesStorage) { OpaqueProperties propCopy(propertiesStorage); - op->getName().destroyOpProperties(propCopy); + // Note: The operation may have been erased in the mean time, so + // OperationName must be stored in this object. + name.destroyOpProperties(propCopy); operator delete(propertiesStorage); propertiesStorage = nullptr; } @@ -1003,13 +1005,14 @@ class ModifyOperationRewrite : public OperationRewrite { if (propertiesStorage) { OpaqueProperties propCopy(propertiesStorage); op->copyProperties(propCopy); - op->getName().destroyOpProperties(propCopy); + name.destroyOpProperties(propCopy); operator delete(propertiesStorage); propertiesStorage = nullptr; } } private: + OperationName name; LocationAttr loc; DictionaryAttr attrs; SmallVector operands;