Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Selecting a preset don't change Hires fix toggle #34

Open
Woisek opened this issue Mar 1, 2023 · 4 comments
Open

Selecting a preset don't change Hires fix toggle #34

Woisek opened this issue Mar 1, 2023 · 4 comments

Comments

@Woisek
Copy link

Woisek commented Mar 1, 2023

When I select a preset that involves the Hires fix options and the options where previously hidden, the selection of the preset doesn't unhide them. The checkbox is selected though, but the options remain hidden. Only an uncheck/check can solve this and unhide it.
Please provide a fix for this.

@Gerschel
Copy link
Owner

Gerschel commented Mar 2, 2023

This one, I can probably squeeze in really soon. It'll be quick to implement.

@Woisek
Copy link
Author

Woisek commented Mar 2, 2023

Great! Looking foreward to it. :)
Thanks!

@Gerschel
Copy link
Owner

I have a conundrum.

A1111 and vladmandic have different implementations of hires fix and hires steps.
I can code for both, I can add conditionals for one scenario then default to the other, but I sense that we will have further diversions.

So I need to come up with a way to test for which version is being used.

@Gerschel
Copy link
Owner

I added the check for vlads shared.url
I put in some handling for hires fix between the two versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants