Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Date Separator #5454

Open
dereklai8 opened this issue Oct 23, 2024 · 1 comment
Open

Duplicate Date Separator #5454

dereklai8 opened this issue Oct 23, 2024 · 1 comment
Assignees
@JcMinarro
Labels
bug Something isn't working

Comments

@dereklai8
Copy link

Describe the bug
Show the same date separator twice

  • Friday, Oct 18
  • Monday, Oct 21

SDK version

  • v6.5.1

To Reproduce
Steps to reproduce the behavior: (App:Chat Sample Compose)

  1. Go to Chat Room 'Petar Velikov'
  2. Scroll up
  3. See duplicate date separator

Expected behavior
Display the date separator only when messages cross to a new date.

Device:

  • Vendor and model: Pixel 6
  • Android version: Android 14

Screenshots
image
@dereklai8 dereklai8 added the bug Something isn't working label Oct 23, 2024
@JcMinarro
Copy link
Member

The default implementation show the Date Separator on case the previous message is older than 4 hours. It can be overrides with a custom DateSeparatorHandler, but we are doing changes to remove this confusing logic and show date separator only when the previous message is on a different day

@JcMinarro JcMinarro self-assigned this Nov 4, 2024
@JcMinarro JcMinarro mentioned this issue Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JcMinarro JcMinarro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JcMinarro @dereklai8