-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo offline support and react-native-firebase #2123
Comments
This issue is known to us, and we're aware of the unfortunate limitations. |
I'm just here to tell you that I have the same problem :-) |
I'm pretty sure you evaluated already some possibilities and I'm a total newbie on everything on the native side, so probably this proposal is totally useless, but maybe its possible to "simply" exchange react-native-quick-sqlite with https://docs.expo.dev/versions/latest/sdk/sqlite/ |
Also, have the same issue. Hope it's fixed soon :) |
Running into this bug as well. Any updates? |
@andreaslydemann are you still stuck with this problem or what did you do? |
I had to drop the offline support on my project, unfortunately, until there is a solution. |
Same here |
@vishalnarkhede could you please share some information with us how you and your team are seeing the priority of this bug/enhancement? This would help me arguing in our company and to plan my next steps a little bit better :-). |
We are discussing this internally, going to prioritize this. Will update you in couple of working days :) |
@andreaslydemann @RRaideRR could you please provide your dependencies list? or complete package.json |
Sure!
|
is it the production build that triggers this issue? @RRaideRR |
The last time I tried it in May / June, it was that I couldn't build locally as well as production build. However, I just tried to create a minimal reproducible example but it seemed to work. I'll get back to you tomorrow :-). |
Yeah I am having a bit hard time trying to reproduce this issue |
Would really appreciate the reproducible repo |
That was some hard work - way more than I thought :-D. Okay - so good news first: @andreaslydemann - I couldn't come up with a minimal reproducible example with firebase and expo-build-properties. So it seems like the initial bug in this thread is fixed (maybe because of a new react-native-quick-sqlite version). Bad news: I still got some errors building my production app on IOS.
How to run the example:
|
Ok so first of all, thanks alot @RRaideRR . That was really helpful. So I finally managed to get an expo app working and getting EAS build to succeed. This is what I had to do (mostly same as what @RRaideRR mentioned, but adding explicit changes in case it helps anyone):
This is not ideal and expo-sqlite has the same issue, but seems like this will be resolved in Expo 50 for |
Thanks for the help figuring this out @RRaideRR and @vishalnarkhede! I'll have a go with the workaround here soon. |
If you're not using expo-update or another library that conflicts with sqlite3, you don't need the workaround with |
By the way: I can confirm that it works for expo 50 out of the box without |
Describe the bug
When you install react-native-firebase in an expo app, it is stated in the docs that you need to set useFrameworks: 'static' with expo-build-properties for react-native-firebase to work. Unfortunately that setting doesn't work with the library react-native-quick-sqlite that is used for offline mode.
You would get the following EAS build error from adding react-native-quick-sqlite while having useFrameworks: 'static' enabled:
That basically makes offline mode impossible together with push notifications using react-native-firebase.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect the app to work with react-native-firebase while having offline support enabled. But that is currently not possible as far as I can see. If Stream used another sqlite library with support for useFrameworks: 'static', that would be a solution.
The text was updated successfully, but these errors were encountered: