Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add possibility to check whether other user have any active device at the moment? #1195

Closed
1 task
Miara opened this issue Oct 2, 2024 · 5 comments
Labels
compose Used to issues related to compose components core Core implementation (LLC, WebRTC, WS..) sample-app Sample app related starter-kit Issue related to one of the starter kit projects xml Used for issues related to XML components

Comments

@Miara
Copy link

Miara commented Oct 2, 2024

Context & proposal

Hi guys!

I want to integrate your SDK, and my business case is that currently I have my own audio/video streaming calls implementation, but I want to use your SDK and I want to control it with feature flag to have both calls (my own old calls, and new calls with your SDK)

I want to make smooth transition to new calls with your SDK, so it could be a situation, that some user using the app that I call to, doesn't have GetStream calls, but only old calls.

How can I check using GetStream SDK if other user has any registered device at the moment - using his ID? How could I achieve it? is it available in your SDK, or it is matter of a new feature?

Acceptance criteria

To accept this task we need to complete the following items:

  • Add method in Stream SDK that allows to ask backend about user presence - whether he has any active device registered - or not.

PS. I tried to ask you about this here: https://github.com/GetStream/stream-video-android/discussions , but It looks like nobody is looking there - that's why I decided to create new ticket.

@Miara Miara added compose Used to issues related to compose components core Core implementation (LLC, WebRTC, WS..) sample-app Sample app related starter-kit Issue related to one of the starter kit projects xml Used for issues related to XML components labels Oct 2, 2024
@Miara
Copy link
Author

Miara commented Oct 2, 2024

Also, when I call somebody that is not registered in GetStream, I such error message:

{"code":4,"message":"GetOrCreateCall failed with error: \"The following users are involved in call create operation, but don't exist: [61b339db7ee7450007267e27]. Please create users before referencing them in a call. It is recommended to create users server-side.\"","StatusCode":400,"duration":"0.00ms","more_info":"https://getstream.io/chat/docs/api_errors_response","details":[]}

But when I look into suggested documentation: https://getstream.io/chat/docs/api_errors_response --> code 4, and status code 400 - are hard to determine whether the reason is not registered user. These codes are to generic

Would it be possible to provide separate code for such case, to not analyze string error mesage?

@aleksandar-apostolov
Copy link
Collaborator

Hi @Miara

I need to check this with the backend and product teams if we want to do it. Usually this kind of stuff would be the responsibility of the integration app.

Btw, we have a notification for the issues but not for the discussions which we check every other week :)

Regards,
Alex

@Miara
Copy link
Author

Miara commented Oct 3, 2024

Thanks Alex!

It is no problem for me to have responsibility of checking if other user has any device registered actively... But how can I do it? 😄

The only way I see is to... compare error_message string from backend response, but I am affraid what happens if backend will change a message.

Code would be much better - as something solid and constant with specific meaning

@aleksandar-apostolov
Copy link
Collaborator

aleksandar-apostolov commented Oct 7, 2024

No, what I mean is that an integration app would have their own backend anyway and can manage this on an integration backend. So basically in your case you would know for which users Stream-calls are enabled etc..

@aleksandar-apostolov
Copy link
Collaborator

Hi @Miara

The correct way to proceed with this is to open a support ticket, so our support team will propagate it correctly to all involved parties.

When you do so, please reference this GitHub issue in your ticket.

Regards,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Used to issues related to compose components core Core implementation (LLC, WebRTC, WS..) sample-app Sample app related starter-kit Issue related to one of the starter kit projects xml Used for issues related to XML components
Projects
None yet
Development

No branches or pull requests

2 participants