Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: dotnet tool install docs should not use an explicit --version arg #4244

Open
2 tasks done
fourpastmidnight opened this issue Oct 4, 2024 · 4 comments
Open
2 tasks done

Comments

@fourpastmidnight
Copy link

fourpastmidnight commented Oct 4, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitVersion.Tool

GitVersion version

6.x

Operating system

Windows

What are you seeing?

I recently installed the dotnet tool for this project following the instructions on the documentation site: dotnet tool install --global GitVersion.Tool --version 5.*. : dotnet tool -g gitversion. Upon installation, running dotnet gitversion /version yields 5.12.0....

I initially forgot I had supplied a --version parameter when installing, hence the genesis of this issue.

What is expected?

I was expecting v6.x which is the currently released version. I expect that the documentation would be updated to not include a --version flag in the example. Perhaps a notice sidebar could be added to the docs to point people to the --version flag if they need to install an older version of the GitVersion.Tools package, such as:

Note

To install an older version of GitVersion.Tools, use the --version flag of dotnet tool install, e.g. dotnet tool install GitVersion.Tool --global --version 5.*

Steps to Reproduce

In the Visual Studio Terminal:

PS C:> dotnet tool -g install gitversion --version 5.*
PS C:> dotnet tool gitversion /version
5.12.0+Branch.support-5.x.Sha.3f75764963eb3d7956dcd5a40488c074dd9faf9e

RepositoryFixture Test

No response

Output log or link to your CI build (if appropriate).

No response

@fourpastmidnight fourpastmidnight changed the title [ISSUE]: dotnet tool is still v5.12.0 even though 6.x has been released [ISSUE]: dotnet tool install docs should not use an explicit --version arg Oct 4, 2024
@arturcic
Copy link
Member

arturcic commented Oct 4, 2024

I think this is a no issue for GitVersion.Tool, that's a dotnet tool thing, closing

@arturcic arturcic closed this as completed Oct 4, 2024
@fourpastmidnight
Copy link
Author

fourpastmidnight commented Oct 4, 2024 via email

@asbjornu
Copy link
Member

asbjornu commented Oct 4, 2024

I agree that we should update the installation instructions and either remove --version altogether or at least set it to version 6 and not 5 as it is now.

@asbjornu asbjornu reopened this Oct 4, 2024
@fourpastmidnight
Copy link
Author

fourpastmidnight commented Oct 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants