Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Passing user objects to MembershipManager methods is deprecated #542

Open
pfrenssen opened this issue Jul 22, 2019 · 1 comment
Open

Passing user objects to MembershipManager methods is deprecated #542

pfrenssen opened this issue Jul 22, 2019 · 1 comment

Comments

@pfrenssen
Copy link
Contributor

pfrenssen commented Jul 22, 2019

In #541 the methods in MembershipManagerInterface that deal with users have had their signatures changed to accept user IDs rather than full AccountInterface objects. A backwards compatibility layer was kept to give users the chance to update their code base without breaking anything.

We need to remove the B/C layer and type hint the $user_id parameters to integers.

@pfrenssen
Copy link
Contributor Author

While testing #541 it was discovered that the Entity API often returns the user ID as a string value, even though it is declared as an integer in the base field definitions. Let's keep the documentation that the user ID should be an integer but not enforce it through a scalar type hint until core is more strict about its data types.

@MPParsley MPParsley mentioned this issue Sep 10, 2019
3 tasks
pfrenssen added a commit to ec-europa/joinup-dev that referenced this issue Jun 9, 2020
…recated.

Deprecated in og:8.1.0-alpha4 and is removed from og:8.1.0-beta1.
See Gizra/og#542.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants