Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added a pull request template to the repository #1123

Closed
wants to merge 2 commits into from
Closed

ci: added a pull request template to the repository #1123

wants to merge 2 commits into from

Conversation

Gmin2
Copy link

@Gmin2 Gmin2 commented Mar 11, 2024

Added a pull request template to the repository

Resolves #1113

Copy link

google-cla bot commented Mar 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Gmin2
Copy link
Author

Gmin2 commented Mar 11, 2024

I have signed the cla
cc @oliverdunk

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more comments, thanks!

@@ -0,0 +1,13 @@
### Pull Request Checklist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a title here since the PR already has a title.

@@ -0,0 +1,13 @@
### Pull Request Checklist

#### [] Description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the checkboxes here? I don't think it makes sense in a heading and I'm not sure GitHub would render it.


#### [] Description

- [] Brief description of the changes made in this PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably doesn't need to be a checklist.


#### [] Issue

- **Fixes** #[issue_number]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the square brackets around the issue number which developers might forget to remove?

firoj0

This comment was marked as off-topic.

@Gmin2 Gmin2 closed this by deleting the head repository Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a pull request template to the repository as like issue template
3 participants