-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample for chrome.commands API #1126
Comments
Realised that many samples already use commands (albeit not custom commands). Closing issue |
hi @hrmtsh2, could you point me towards any of these samples? much appreciated |
Well, coming back to this issue, I have been unable to find a single sample that explicitly uses the "command" property in the manifest (I swear I saw many when I closed the issue!). Even if there were, it was certainly small in number, and many samples do not, in fact, demonstrate the commands API. |
Hi @hrmtsh2, an example of an extension using the manifest declaration would be this one: https://github.com/GoogleChrome/chrome-extensions-samples/tree/main/api-samples/default_command_override The only thing I don't see right now is an example of an extension using the getAll method. I think a new sample demonstrating that or updating an existing sample would make sense, if you want to work on something :) |
Sorry I was unable to find this before.
|
I would like to write a sample for chrome.commands.
The idea is to have keyboard shortcuts trigger dark/light mode (through content script injection). It could have different shortcuts for different functionalities (say, one for dark mode and another for embedding reading time estimate).
@oliverdunk @jpmedley kindly give suggestions or the go-ahead.
The text was updated successfully, but these errors were encountered: