Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Switch to Java 17 for all Dataflow Templates #2050

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Switch to Java 17 for all Dataflow Templates #2050

wants to merge 9 commits into from

Conversation

liferoad
Copy link
Contributor

@liferoad liferoad commented Dec 5, 2024 •
edited
Loading

Fixes #2051

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (8e7ae4f) to head (36f379e).

Files with missing lines Patch % Lines
...am/it/gcp/artifacts/matchers/ArtifactsSubject.java 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2050      +/-   ##
============================================
- Coverage     46.35%   46.33%   -0.02%     
- Complexity     3931     4256     +325     
============================================
  Files           858      858              
  Lines         51259    51265       +6     
  Branches       5391     5391              
============================================
- Hits          23760    23756       -4     
- Misses        25786    25796      +10     
  Partials       1713     1713
Components Coverage Δ
spanner-templates 68.15% <ø> (-0.03%) ⬇️
spanner-import-export 65.57% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 76.42% <ø> (ø)
spanner-live-reverse-replication 77.66% <ø> (-0.07%) ⬇️
spanner-bulk-migration 87.22% <ø> (ø)
Files with missing lines Coverage Δ
...gle/cloud/teleport/plugin/DockerfileGenerator.java 90.56% <ø> (ø)
...am/it/gcp/artifacts/matchers/ArtifactsSubject.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@Abacn
Copy link
Contributor

Abacn commented Dec 5, 2024

there is a single test failure from the report: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/2050/checks?check_run_id=33950822829

expected to contain hash: 81f7b7afd932b4754caaa9ba6ced7a8bcb2cbfec6857cf823e4d112125c6e939
but was                 : [org.apache.beam.it.gcp.artifacts.GcsArtifact@40673c72]
	at com.google.cloud.teleport.templates.BulkCompressorIT.baseCompress(BulkCompressorIT.java:85)
	at com.google.cloud.teleport.templates.BulkCompressorIT.testCompressGzip(BulkCompressorIT.java:55)

This is expected. The original assert was too strict, see

https://stackoverflow.com/questions/77305259/change-in-gzipoutputstream-behavior-in-java-17

@Abacn
Copy link
Contributor

Abacn commented Dec 5, 2024

Kafka PR running on https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12183265029

Spanner PR running on https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12183272085

@liferoad liferoad mentioned this pull request Dec 5, 2024
Open
@liferoad liferoad changed the title [DO NOT MERGE] Test Java 17 [DO NOT MERGE] Switch to Java 17 for all Dataflow Templates Dec 13, 2024
@liferoad
Copy link
Contributor Author

TODO: fix #2050 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polber Polber Polber requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
improvement size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Use Java 17 for Dataflow Templates
3 participants
@liferoad @Abacn @Polber