Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base CPU/Memory Requests on Actual Usage #591

Open
askmeegs opened this issue Aug 12, 2021 · 6 comments · May be fixed by #2540
Open

Base CPU/Memory Requests on Actual Usage #591

askmeegs opened this issue Aug 12, 2021 · 6 comments · May be fixed by #2540
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.

Comments

@askmeegs
Copy link
Contributor

askmeegs commented Aug 12, 2021 •
edited by NimJay
Loading

Original issue title: Adjust CPU/Memory requests based on actual resource footprint

  1. Analyze a running version of Online Boutique to determine the actual CPU / Memory usage of each service
  2. Adjust CPU/Memory requests + limits in the Deployment YAMLs as needed
  3. Document the overall CPU / Memory usage of the app
@askmeegs askmeegs added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Aug 12, 2021
@askmeegs
Copy link
Contributor Author

Bumping down to a P3.

@askmeegs askmeegs added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 17, 2021
@NimJay NimJay changed the title Adjust CPU / Memory requests based on actual resource footprint Adjust CPU/Memory requests based on actual resource footprint Nov 22, 2021
@NimJay NimJay changed the title Adjust CPU/Memory requests based on actual resource footprint Base CPU/Memory Requests on Actual Usage Nov 22, 2021
@bourgeoisor
Copy link
Member

This is from a 7-day period of time:

image
image
image
image
image
image
image
image
image
image
image

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 3, 2022 •
edited
Loading

It would be ideal to review the CPU/Memory requests to see if we could review the minimum of 4 nodes for GKE in order to get Online Boutique deployed. Online Boutique should be able to work on a default GKE of 3 nodes with the default size.

@NimJay
Copy link
Collaborator

NimJay commented Mar 27, 2023

Update to cool down this ticket:

@minherz
Copy link
Contributor

minherz commented Sep 19, 2023

Closed due no demand for this FR from stakeholders.

@minherz minherz closed this as completed Sep 19, 2023
@NimJay NimJay reopened this May 10, 2024
@NimJay NimJay linked a pull request May 10, 2024 that will close this issue
Open
@NimJay NimJay added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 10, 2024
@NimJay
Copy link
Collaborator

NimJay commented May 10, 2024 •
edited
Loading

I'm reviving and bumping priority on this because Online Boutique is used by Jump Start Solution (JSS): https://github.com/GoogleCloudPlatform/terraform-ecommerce-microservices-on-gke
And we need to bring the cost of that JSS down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Base resource requests on actual usage GoogleCloudPlatform/microservices-demo
5 participants
@askmeegs @bourgeoisor @minherz @NimJay @mathieu-benoit