Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”¨[refactor] [v1.0.0] ν”„λ‘œλ•μ…˜μš© 배포 μ€€λΉ„ #89

Closed
ImNM opened this issue Jul 31, 2022 · 11 comments
Assignees
Labels
For: Deploy [μ΄μŠˆλŒ€μƒ] 배포에 κ΄€ν•œ 이슈 Type: Refactor [이슈 λͺ©μ ] ν”„λ‘œλ•μ…˜ μ½”λ“œ λ¦¬νŒ©ν† λ§

Comments

@ImNM
Copy link
Member

ImNM commented Jul 31, 2022

πŸ”¨ λ¦¬νŒ©ν† λ§μ΄ ν•„μš”ν•œ λΆ€λΆ„

ν™”μš”μΌ 밀에 (8μ›” 2일 ) λ°±μ—”λ“œ 회의 진행할 μ˜ˆμ •μž…λ‹ˆλ‹€.

λ¦¬νŒ©ν† λ§ μž‘μ—… 브런치

각 κ°œμ„ μ  refactor ν•­λͺ©μœΌλ‘œ

βœ… refactoring TODO

  • [ ]
@ImNM ImNM added For: Deploy [μ΄μŠˆλŒ€μƒ] 배포에 κ΄€ν•œ 이슈 Type: Refactor [이슈 λͺ©μ ] ν”„λ‘œλ•μ…˜ μ½”λ“œ λ¦¬νŒ©ν† λ§ labels Jul 31, 2022
@ImNM
Copy link
Member Author

ImNM commented Jul 31, 2022

ν…ŒμŠ€νŠΈ ν†΅κ³Όν•˜κ²Œλ” μœ μ € μ„œλΉ„μŠ€ μˆ˜μ •

@ImNM
Copy link
Member Author

ImNM commented Aug 1, 2022

μ–΄μ„ΈμŠ€ν† ν° λ‹΄λŠ”μ •λ³΄ (κ΄€λ¦¬μžλ‘œκ·ΈμΈ ) 길이 μˆ˜μ •

@ImNM
Copy link
Member Author

ImNM commented Aug 1, 2022

μ‘μ›λŒ“κΈ€ λ Œλ€ν•˜κ²Œ λ½‘μ•„μ˜€λŠ” api μΆ”κ°€

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

μœ μ € μ‘°νšŒμ‹œ createdAt
λŒ“κΈ€ 쑰회 μ„±κ³΅μ‹œ μœ μ €μ •λ³΄ λΉΌκΈ° ,
μœ μ € μ‘°νšŒμ‹œ 검색 μ „ν™”λ²ˆν˜Έ, 이름

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

https://api.gosrock.band/api-docs/#/tickets/TicketsController_getAllTicketsById
μš”μ²­ μ„±κ³΅μ‘λ‹΅μ‹œ
μœ μ € 정보 λΉΌκΈ°
μ–΄λ“œλ―Ό 정보도 ν•„μš”μ—†κ²Ÿμ§•

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

https://api.gosrock.band/api-docs/#/tickets/TicketsController_postTicketEntryValidation
ν™•μΈλŒ€κΈ° 인 티켓인데 μ—λŸ¬λ©”μ‹œμ§€κ°€
{
"statusCode": 400,
"timestamp": "2022-08-02T12:56:56.031Z",
"path": "/v1/tickets/uzByTqadZLoGPo/enter",
"method": "POST",
"error": {
"message": "이미 μž…μž₯ μ™„λ£Œλœ ν‹°μΌ“μž…λ‹ˆλ‹€",
"error": "BadRequestException",
"statusCode": 400
}
}
μ΄κ±°μž„
@gengminy

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

https://api.gosrock.band/api-docs/#/tickets/TicketsController_updateTicketStatus

οΏ½ν‹°μΌ“ μƒνƒœ 변경을 ν–ˆλŠ”λ°
ν‹°μΌ“ μž…μž₯ μ•ŒλžŒμ΄ 와버림
@sanbonai06

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

https://api.gosrock.band/api-docs/#/tickets/TicketsController_getTicketsWith

.orderBy('ticket.createdAt', pageOptionsDto.order)

createdAt이 μ•„λ‹Œ id κΈ°μ€€μœΌλ‘œ!
@gengminy

@ImNM
Copy link
Member Author

ImNM commented Aug 2, 2022

export class PageOptionsDto {
  @ApiPropertyOptional({ enum: PageOrder, default: PageOrder.ASC })
  @IsEnum(PageOrder)
  @IsOptional()
  @Expose()
  readonly order: PageOrder = PageOrder.ASC;

  @ApiPropertyOptional({
    minimum: 1,
    default: 1
  })
  @Type(() => Number)
  @IsInt()
  @Min(1)
  @IsOptional()
  @Expose()
  readonly page: number = 1;

  @ApiPropertyOptional({
    minimum: 1,
    maximum: 50,
    default: 10
  })
  @Type(() => Number)
  @IsInt()
  @Min(1)
  @Max(50)
  @IsOptional()
  @Expose()
  readonly take: number = 10;

  get skip(): number {
    return (this.page - 1) * this.take;
  }
}

IMG_B4CFF2950BD8-1

skip μ΄λž‘ takeκ°€ μ˜΅μ…”λ„μ΄λΌμ„œ λ°±μ—”λ“œ 였λ₯˜ λ°œμƒ
@gengminy

@kim-wonjin
Copy link
Member

κ΄€λ¦¬μž ν˜„ν™©μ‘°νšŒ κ³΅μ§œν‹°μΌ“ 갯수 μΆ”κ°€

@kim-wonjin
Copy link
Member

κ΄€λ¦¬μž 주문쑰회 νŽ˜μ΄μ§€λ„€μ΄μ…˜ isFree λ‹€μ‹œ λ„£κΈ°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: Deploy [μ΄μŠˆλŒ€μƒ] 배포에 κ΄€ν•œ 이슈 Type: Refactor [이슈 λͺ©μ ] ν”„λ‘œλ•μ…˜ μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
Status: Done
Development

No branches or pull requests

5 participants