Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for unquoted values of (Yes) and (No) in choice questions #830

Open
gregelin opened this issue Apr 9, 2020 · 0 comments
Open
Labels

Comments

@gregelin
Copy link
Contributor

gregelin commented Apr 9, 2020

"Yes" and "No" are special keywords in YAML that map to boolean True and False.

Choice questions render "True" and "False" as only option if the choice questions uses

    text: Yes
    ...
    text: No

instead of

    text: "Yes"
    ...
    text: "No"

This should actually be made to fail our validator since a boolean is the wrong data type for the text of a choice. To get the string Yes and No, they should be wrapped in quotation marks, i.e.:

text: "Yes"
...
text: "No"
@gregelin gregelin added the better label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant