Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera auto-switching is too aggressive (8 Pro) #410

Closed
0xunusedusername opened this issue Jan 17, 2024 · 8 comments
Closed

Camera auto-switching is too aggressive (8 Pro) #410

0xunusedusername opened this issue Jan 17, 2024 · 8 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@0xunusedusername
Copy link

I'm at 1x zoom, intending to use the primary camera at close focus to blur the background, but the camera keeps switching to the ultrawide instead.

The Google Camera app does not behave like this. It would be nice if we could have some lens selection shortcuts or a toggle to disable auto-switching without crossing the zoom threshold.

@thestinger
Copy link
Member

It behaves exactly the same way as Google Camera, switching at the same level it would switch. There's just not a button for going back to exactly 1x. This is a duplicate of #87.

@thestinger thestinger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@thestinger thestinger added duplicate This issue or pull request already exists enhancement New feature or request labels Jan 17, 2024
@0xunusedusername
Copy link
Author

It doesn't though. I'm using them back-to-back and GCam doesn't switch.

It behaves exactly the same way as Google Camera, switching at the same level it would switch. There's just not a button for going back to exactly 1x. This is a duplicate of #87.

@thestinger
Copy link
Member

It sounds like you're talking about the macro feature, which has a toggle in Google Camera. That's not the same thing.

@thestinger thestinger added question Further information is requested duplicate This issue or pull request already exists enhancement New feature or request and removed duplicate This issue or pull request already exists enhancement New feature or request question Further information is requested labels Jan 17, 2024
@thestinger
Copy link
Member

This is a duplicate of #403 if it's about adding a toggle for the macro feature.

@0xunusedusername
Copy link
Author

I am not, just talking about a short focus distance (Macro mode actually shows up as 'Not Available' in the quick settings).

It sounds like you're talking about the macro feature, which has a toggle in Google Camera. That's not the same thing.

@thestinger
Copy link
Member

You're either talking about one of those two things. The zoom works the same as Google Camera.

@thestinger
Copy link
Member

This zoom-based camera switching is not implemented inside either Google Camera or GrapheneOS Camera. It's done inside the OS, and it's the same implementation. There's limited configuration for it. We don't do anything special. The only part that's implemented in our app is the zoom slider and zoom gestures. The zoom itself is done via a standard Camera2 APi which has camera switching based on zoom level and other factors such as distance to options, light level, etc. depending on the setup.

@0xunusedusername
Copy link
Author

Yeah, I messed up. Google lets you do manual lens selection on the 8p, which got enabled somehow. Would be nice to see it ported, though.

Sorry, my fault.

This zoom-based camera switching is not implemented inside either Google Camera or GrapheneOS Camera. It's done inside the OS, and it's the same implementation. There's limited configuration for it. We don't do anything special. The only part that's implemented in our app is the zoom slider and zoom gestures. The zoom itself is done via a standard Camera2 APi which has camera switching based on zoom level and other factors such as distance to options, light level, etc. depending on the setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants