Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews are not visible #460

Open
Jennifer2005x opened this issue Aug 3, 2024 · 23 comments
Open

Previews are not visible #460

Jennifer2005x opened this issue Aug 3, 2024 · 23 comments

Comments

@Jennifer2005x
Copy link

I have a phone with Android 10 and I love this camera and how private it is, I only have this problem, the previews are seen from the small button but when I want to see them it does not appear, I hope they fix it, it is a good camera

Screenshot_20240802-185735_Camera_1
Screenshot_20240802-185740_Camera_1

@matchboxbananasynergy
Copy link

matchboxbananasynergy commented Aug 3, 2024

Which version of the camera app are you using?

@Jennifer2005x
Copy link
Author

Which version of the camera app are you using?

The last one, the 73

@MHShetty
Copy link
Member

MHShetty commented Aug 3, 2024

Hi @Jennifer2005x,

Thanks a lot for reporting this issue and sorry for the inconvenience you're facing.

Did this issue exist on your device in v72?

@Jennifer2005x
Copy link
Author

Hi @Jennifer2005x,

Thanks a lot for reporting this issue and sorry for the inconvenience you're facing.

Did this issue exist on your device in v72?

Since I downloaded the app (approximately a few months) I have had that problem, until now I found out that they have github

@MHShetty
Copy link
Member

MHShetty commented Aug 3, 2024

Since I downloaded the app (approximately a few months) I have had that problem, until now I found out that they have github

Ah that seems unusual. Could you please share the logcat while trying to access the in-app gallery? If any internal/app level component logs this issue, we could dive in deeper to see what went wrong

Also, by any little chance, does the image show up when the device is rotated in horizontal orientation?

@Jennifer2005x
Copy link
Author

Since I downloaded the app (approximately a few months) I have had that problem, until now I found out that they have github

Ah that seems unusual. Could you please share the logcat while trying to access the in-app gallery? If any internal/app level component logs this issue, we could dive in deeper to see what went wrong

Also, by any little chance, does the image show up when the device is rotated in horizontal orientation?

2024-08-03-22-38-10.txt

And no, the image does not appear when changing the orientation

@MHShetty
Copy link
Member

MHShetty commented Aug 4, 2024

Hi @Jennifer2005x,

I don't think there's anything relevant in the logs unfortunately. Not being able to reproduce this behavior makes it harder to know what could have gone wrong there, I think we'll need to share a debug build with some more log messages to debug this further. I'll share a debug apk here soon.

Also, are you able to see the details of the photo while clicking on the info icon in the top navigation bar? We could know if it's a rendering problem an issue with loading the saved image uris that way to further narrow down to the exact issue

@Jennifer2005x
Copy link
Author

Hi @Jennifer2005x,

I don't think there's anything relevant in the logs unfortunately. Not being able to reproduce this behavior makes it harder to know what could have gone wrong there, I think we'll need to share a debug build with some more log messages to debug this further. I'll share a debug apk here soon.

Also, are you able to see the details of the photo while clicking on the info icon in the top navigation bar? We could know if it's a rendering problem an issue with loading the saved image uris that way to further narrow down to the exact issue

Screenshot_20240804-044045_Camera

@MHShetty
Copy link
Member

MHShetty commented Aug 4, 2024

The issue seems to be with the rendering in that case. Could be related to the bitmap (image) being too large for the device to render due to memory constraints or other reasons

@MHShetty
Copy link
Member

MHShetty commented Aug 4, 2024

Could you please try out the debug apk in the below link for this issue?

https://drive.proton.me/urls/ZE8YSCMNSG#bJjXGQs8RUzU

@Jennifer2005x
Copy link
Author

Jennifer2005x commented Aug 4, 2024

Could you please try out the debug apk in the below link for this issue?

https://drive.proton.me/urls/ZE8YSCMNSG#bJjXGQs8RUzU

Still the same

Screenshot_20240804-135532_Camera d_1
Screenshot_20240804-135537_Camera d

@MHShetty
Copy link
Member

MHShetty commented Aug 5, 2024

Hi @Jennifer2005x,

Sorry to keep you waiting. I have maximized our existing image downscaling logic to a high extent to confirm that this is a rendering/memory related issue in the debug apk uploaded in the link below:

https://drive.proton.me/urls/4V5PXPA2R8#OEzrJI1XgZz7

Could you please try this debug apk to check if you're able to view a low-quality image of a recently taken photo? We could look for better image down scaling algorithm or constant to see if that could resolve the issue

@Jennifer2005x
Copy link
Author

Jennifer2005x commented Aug 6, 2024

Hi @Jennifer2005x,

Sorry to keep you waiting. I have maximized our existing image downscaling logic to a high extent to confirm that this is a rendering/memory related issue in the debug apk uploaded in the link below:

https://drive.proton.me/urls/4V5PXPA2R8#OEzrJI1XgZz7

Could you please try this debug apk to check if you're able to view a low-quality image of a recently taken photo? We could look for better image down scaling algorithm or constant to see if that could resolve the issue

It works, but it looks blurry

Screenshot_20240806-131842_Camera d_1
Screenshot_20240806-131853_Camera d

@MHShetty
Copy link
Member

MHShetty commented Aug 6, 2024

It works, but it looks blurry

Yes that's the expected behavior, we just downscaled the image to a great extent to confirm that the issue lies there. I'll share an apk file for testing, once we have a fix ready for the same. Thanks a lot for your time and help!

@MHShetty
Copy link
Member

MHShetty commented Aug 7, 2024

Hi @Jennifer2005x,

Could you please share the device model you're using for the camera app?

@MHShetty
Copy link
Member

MHShetty commented Aug 7, 2024

Also, could you please try this test apk on your device? https://drive.proton.me/urls/3YKPK5YC04#YJ4JHLjq2ydu

@Jennifer2005x
Copy link
Author

Hi @Jennifer2005x,

Could you please share the device model you're using for the camera app?

It's a Samsung A022M

@Jennifer2005x
Copy link
Author

Jennifer2005x commented Aug 7, 2024

Also, could you please try this test apk on your device? https://drive.proton.me/urls/3YKPK5YC04#YJ4JHLjq2ydu

Same

Screenshot_20240807-155949_Camera d_1
Screenshot_20240807-160003_Camera d

@MHShetty
Copy link
Member

MHShetty commented Aug 13, 2024

Hi @Jennifer2005x,

Could you please test the following debug apk on your device to check if it the preview is visible in the latest changes?

https://drive.proton.me/urls/WAJBQ22PJC#cve6AwLBGj7z

@Jennifer2005x
Copy link
Author

It works more or less
Screenshot_20240813-164926_Camera d
Screenshot_20240813-164942_Camera d

@MHShetty
Copy link
Member

Glad to know that it's working as expected.

Will make a PR to include this fix soon after a issue with the new implementation gets addressed and after some testing.

Thanks for confirming @Jennifer2005x!

@MHShetty
Copy link
Member

MHShetty commented Aug 15, 2024

Hi @Jennifer2005x,

Could you please test the in-app gallery of the app present in the following apk?

https://drive.proton.me/urls/0HAM7AYBEW#VoqTarq9Ypho

@Jennifer2005x
Copy link
Author

It looks good now
Screenshot_20240815-124718_Camera d
Screenshot_20240815-124730_Camera d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants