Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preface CMake build variables with HDF5 to avoid conflicts #4712

Open
byrnHDF opened this issue Aug 14, 2024 · 1 comment
Open

Preface CMake build variables with HDF5 to avoid conflicts #4712

byrnHDF opened this issue Aug 14, 2024 · 1 comment
Assignees
Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Milestone

Comments

@byrnHDF
Copy link
Contributor

byrnHDF commented Aug 14, 2024

When HDF5 is used as a subproject - conflicts could occur with general named variables.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Sep 12, 2024

These should be prefixed with "HDF5_"
BUILD_SHARED_LIBS "Build Shared Libraries" ON
BUILD_STATIC_LIBS "Build Static Libraries" ON
BUILD_STATIC_EXECS "Build Static Executables" OFF
BUILD_TESTING "Build HDF5 Unit Testing" ON
ONLY_SHARED_LIBS "Only Build Shared Libraries" OFF
ALLOW_UNSUPPORTED "Allow unsupported combinations of configure options" OFF
DEFAULT_API_VERSION "Enable default API (v16, v18, v110, v112, v114, v116)" "v116"
TEST_SHELL_SCRIPTS "Enable shell script tests" ON
PLUGIN_USE_EXTERNAL "Use External Library Building for PLUGINS else search" OFF

These should be left alone
ZLIB_*
SZIP_*
LIBAEC_*

@byrnHDF byrnHDF added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Documentation Doxygen, markdown, etc. Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality labels Oct 15, 2024
@byrnHDF byrnHDF added this to the 2.0.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

No branches or pull requests

1 participant