problems with newer mysql modules

[rwf14f]

Which version of the mysql::server module are you using?

I get a lot of errors when I try it with my version (mysql::server version > 2.0):

• in apelpublisher::config::mysql:
  • config_hash parameter doesn't exist in newer versions
• in apelpublisher::create_database:
  • dependency Database[$mysql_database] can't be satisfied, it works if I change it to Mysql_database[$mysql_database]]
  • in the onlyif you use "use apelclient; ...", but you allow to pass $mysql_database, so it should be "use ${mysql_database}"
• in apelpublisher::db_permissions:
  • database_grant has been deprecated in favor of mysql_grant
  • database_grant fails with SQL syntax errors, probably a problem in the mysql module (maybe caused by the deprecation of database_grant)

[rwf14f]

The SQL syntax errors in database_grant are caused by the single quotes in the title.
It works if I use "${mysql_user}@${host}/${mysql_database}". The module adds the single quotes automatically, so it ends up with two single quotes around the user and host.

[rwf14f]

Kashif fixed these problems in the oxford fork, can they be merged ?

[kreczko]

Unfortunately the changes can't be merged automatically. But it is definitely better if we update this.
I will probably have some time on Friday to do the manual merge.

[rwf14f]

I had another look at Kashif's changes and I'm not sure if we should merge all of them, e.g. the explicit hiera calls in params.pp shouldn't be in the official module. The critical bits are the mysql changes.
I'm going to merge Kashif's fixes into my own fork tomorrow. If you want I can do the pull request from my updated fork..