Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize PolyBeam, PerturbedPolyBeam, and ZenikeBeam through obsparam #184

Open
piyanatk opened this issue Oct 11, 2021 · 1 comment
Open

Comments

@piyanatk
Copy link
Contributor

Currently this is not possible because the pyuvsim interface under the hood only know about AnalyticBeam. These beam can be used by pyuvsim, but keeping these beams here make the most sense because they are specific to HERA.

Some ideas for workaround

  1. Open an issue in pyuvsim to allow "other" analytic beam type
  2. Use an extra keyword in the obsparam to specify these beams. This keyword should be passed to the UVData object. We then reinitialize the beam.
  3. Write our own obsparam initialization
@steven-murray
Copy link
Contributor

I feel like the right way to do this is actually to fix the AnalyticBeam API. At the moment it is completely non-modular, and only allows you to specify specific strings to get different kinds of beams. It should define different beams as objects with a specific API that can be defined outside the original code. This will require talking to RASG -- I know there are plans to move the uvbeam stuff around.

Calling in @bhazelton and @dannyjacobs for comments here.

@piyanatk piyanatk changed the title Initialize PolyBeam, PerturbedPolayBean, and ZenikeBeam through obsparam Initialize PolyBeam, PerturbedPolayBeam, and ZenikeBeam through obsparam Oct 11, 2021
@piyanatk piyanatk changed the title Initialize PolyBeam, PerturbedPolayBeam, and ZenikeBeam through obsparam Initialize PolyBeam, PerturbedPolyBeam, and ZenikeBeam through obsparam Oct 11, 2021
@steven-murray steven-murray self-assigned this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants