Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_grantRole in AccessControl.sol is private #302

Open
alexroan opened this issue Apr 16, 2020 · 1 comment
Open

_grantRole in AccessControl.sol is private #302

alexroan opened this issue Apr 16, 2020 · 1 comment

Comments

@alexroan
Copy link

_grantRole(DEFAULT_ADMIN_ROLE, root);

_grantRole() in AccessControl.sol is current private, so cannot be called by child contracts.

See here

@alcueca
Copy link
Contributor

alcueca commented Apr 16, 2020

Hierarchy.sol is implemented using the 3.0.0-rc.0 version of AccessControl.sol, in which _grantRole() was still internal. We have PR #295 to migrate to 3.0.0-rc.1, in which we have this issue. I'll replace every call to _grantRole in a constructor by a call to _setupRole.

I think all the other calls to _grantRole can be replaced by calls to the public one, grantRole.

Am I missing anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants