Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics error occurs when an @ is used in the file path #8086

Open
RustyMoyher opened this issue Apr 1, 2019 · 7 comments · May be fixed by #11413
Open

Diagnostics error occurs when an @ is used in the file path #8086

RustyMoyher opened this issue Apr 1, 2019 · 7 comments · May be fixed by #11413
Assignees
@Simn
Labels
bug feature-ide IDE / Editor support
Milestone
Later

Comments

@RustyMoyher
Copy link

If the path of a file has an @ in it, an error will occur with diagnostics.

For example, I have a folder called @Projects. This causes the error to occur in VSCode when I save.

Invalid format: Projects/FlixelTut/source/PlayState.hx

The issue appears to be a compiler bug, probably a string.split() that goes wrong. Based on discussions with @Gama11 in Discord, we believe that Haxe does a a naive string split on @, assuming that can't appear in file paths.
@Gama11 Gama11 added bug feature-ide IDE / Editor support labels Apr 1, 2019
@Simn
Copy link
Member

Simn commented Apr 2, 2019

I... don't think this can be fixed in the old protocol.

@Simn Simn added this to the Release 4.1 milestone Apr 2, 2019
@Gama11
Copy link
Member

Gama11 commented Apr 2, 2019

Why not? The @displaymode can only appear at the end, right?

@Simn
Copy link
Member

Simn commented Apr 2, 2019

Yes but the position is also separated with a @. It's file@pos@mode, and the mode is optional. So with fi@le@pos@mode we are in a bad spot.

@Gama11
Copy link
Member

Gama11 commented Apr 2, 2019

I'm not sure that can actually happen though? Or is @ a valid character in a module name?

The original issue here is with @ in an earlier part of the path.

@Simn
Copy link
Member

Simn commented Apr 2, 2019

Not sure what you mean, something like /something/@Projects/File.hx@12@position is just the case I mention. Or do you think we should try to find the File.hx first and then take it from there?

@Gama11
Copy link
Member

Gama11 commented Apr 2, 2019

Something like that, yeah.

@Simn Simn self-assigned this Feb 19, 2020
@nadako nadako modified the milestones: Release 4.1, Release 4.2 Apr 5, 2020
@Simn Simn modified the milestones: Release 4.3, Later Mar 24, 2023
@kLabz
Copy link
Contributor

kLabz commented Jul 19, 2024

Should be fine now that diagnostics have been moved to Json RPC

@kLabz kLabz linked a pull request Jul 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
bug feature-ide IDE / Editor support
Projects
None yet
Milestone
Later
Development

Successfully merging a pull request may close this issue.

[display] Remove legacy diagnostics HaxeFoundation/haxe
6 participants
@nadako @Simn @RustyMoyher @Gama11 @RealyUniqueName @kLabz