Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using user instanceof ChatUser. #145

Open
BlitzOffline opened this issue Aug 28, 2022 · 0 comments
Open

Stop using user instanceof ChatUser. #145

BlitzOffline opened this issue Aug 28, 2022 · 0 comments
Labels
Enhancement Request for a new feature, or to change an existing one.

Comments

@BlitzOffline
Copy link
Member

In many places we use unnecessary checks and casts. Instead we should just add new methods to User and just make ChatUser return its own stuff, and let people decide how their own user implementation should work.

A good example is the new User#hasPermission method I've added in #144.
@BlitzOffline BlitzOffline added the Enhancement Request for a new feature, or to change an existing one. label Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Request for a new feature, or to change an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlitzOffline