Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Unfocus first MenuList item on page load #339

Closed
wants to merge 4 commits into from
Closed

Unfocus first MenuList item on page load #339

wants to merge 4 commits into from

Conversation

JoshuaPawlik
Copy link

Summary of changes:

  • This will unfocus the first MenuList item that had been thought to be stuck in hover state. It was actually automatically focused by the line of code I removed.

Behaviors that should be QA'd:

  • Tab/Arrow Key functionality when switching focused items to make sure it works as desired/expected.

Github Issues closed by this PR:

@merlinbot
Copy link

Messages
📖 
### Modified Components
* Menu

PR Application

Generated by 🚫 dangerJS

brad-decker
brad-decker previously approved these changes Jan 25, 2019
View reviewed changes
AriLFrankel
AriLFrankel suggested changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@AriLFrankel AriLFrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change request but otherwise looks good. Thank you!

src/components/Menu/MenuList.js Outdated Show resolved Hide resolved
AriLFrankel
AriLFrankel previously approved these changes Jan 25, 2019
View reviewed changes
@brad-decker brad-decker closed this Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brad-decker brad-decker brad-decker left review comments

@AriLFrankel AriLFrankel AriLFrankel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabIndex in Menu
4 participants
@JoshuaPawlik @merlinbot @brad-decker @AriLFrankel