Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About debug and log #22

Open
lwhile opened this issue Jul 27, 2022 · 0 comments
Open

About debug and log #22

lwhile opened this issue Jul 27, 2022 · 0 comments

Comments

@lwhile
Copy link

lwhile commented Jul 27, 2022

  1. About debug:
    I think fmt.PrintX in code can be replaced by logger.

ethereum-watcher/watcher.go

Line 478 in 2c339ec

fmt.Println("removing tail block:", watcher.SyncedBlocks.Back())

  1. About log:
    Allow package users to choose whether to use the logger. For example, provide a debug mode.

Also, I can provide a PR if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lwhile