Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech] Update mm ext #1151

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Tech] Update mm ext #1151

wants to merge 7 commits into from

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Nov 13, 2024 •
edited
Loading

@BrettCleary BrettCleary self-assigned this Nov 13, 2024
@flavioislima
Copy link
Contributor

Tested here on a clean node modules and build folder and it works pretty well in dev mode.

@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Nov 14, 2024
flavioislima
flavioislima approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@jiyuu-jin jiyuu-jin Awaiting requested review from jiyuu-jin

@eliobricenov eliobricenov Awaiting requested review from eliobricenov

At least 2 approving reviews are required to merge this pull request.

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Review PR is ready to be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @flavioislima