You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Bytes-Explorer i caved on proglang_select, but now we're repeating this pattern for a different column name? We can't have a new transform for every attribute we want to annotate/filter on. I recommend 1 of the following
Extend filter transform so that instead of removing rows, it optionally allows, keeping all rows, but adds a new column that is set to True for what "would have been filtered" cc: @cmadam
Create a new transform that generalizes what proglang_select does for an arbitrary column and set of values.
I would strongly recommend one of these alternatives to creating a new special purpose transform. We're a toolkit after all.
These are two separate functionalities and we need to think from a view of how an end user will use it. There can be many transforms that will use filtering at the end to filter. However coupling all the functionalities together may make it hard for an end user to use the toolkit, esp when the number of functionalities grow.
Search before asking
Component
Transforms/code/code_quality
Feature
Capability to filter by permissive licenses for any new code data as a new module.
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: