Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add license filtering for code modules #139

Closed
2 tasks done
Bytes-Explorer opened this issue May 16, 2024 · 4 comments
Closed
2 tasks done

[Feature] Add license filtering for code modules #139

Bytes-Explorer opened this issue May 16, 2024 · 4 comments
Assignees
Labels
current-priority enhancement New feature or request good first issue Good for newcomers

Comments

@Bytes-Explorer
Copy link
Collaborator

Bytes-Explorer commented May 16, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Transforms/code/code_quality

Feature

Capability to filter by permissive licenses for any new code data as a new module.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Bytes-Explorer
Copy link
Collaborator Author

Needed for release 1

@daw3rd
Copy link
Member

daw3rd commented Jun 18, 2024

@Bytes-Explorer i caved on proglang_select, but now we're repeating this pattern for a different column name? We can't have a new transform for every attribute we want to annotate/filter on. I recommend 1 of the following

  1. Extend filter transform so that instead of removing rows, it optionally allows, keeping all rows, but adds a new column that is set to True for what "would have been filtered" cc: @cmadam
  2. Create a new transform that generalizes what proglang_select does for an arbitrary column and set of values.

I would strongly recommend one of these alternatives to creating a new special purpose transform. We're a toolkit after all.

@Bytes-Explorer
Copy link
Collaborator Author

These are two separate functionalities and we need to think from a view of how an end user will use it. There can be many transforms that will use filtering at the end to filter. However coupling all the functionalities together may make it hard for an end user to use the toolkit, esp when the number of functionalities grow.

@daw3rd
Copy link
Member

daw3rd commented Sep 13, 2024

This is in progress in PR #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current-priority enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants