Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Python launcher error when the child process dies #770

Open
1 of 2 tasks
sujee opened this issue Nov 5, 2024 · 2 comments
Open
1 of 2 tasks

[Bug] Python launcher error when the child process dies #770

sujee opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch

Comments

@sujee
Copy link
Contributor

sujee commented Nov 5, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Library/core

What happened + What you expected to happen

Code : https://github.com/IBM/data-prep-kit/blob/dev/examples/notebooks/intro/dpk_intro_1_python.ipynb

We launch the python launcher like this

launcher = PythonTransformLauncher(Pdf2ParquetPythonTransformConfiguration())
return_code = launcher.launch()

When the process dies, the reporting code errors out as follows:

Traceback (most recent call last):
  File "/home/sujee/apps/anaconda3/envs/dpk-5-basic-022dev2-py312/lib/python3.12/site-packages/data_processing/runtime/pure_python/transform_orchestrator.py", line 131, in orchestrate
    stats["processing_time"] = round(stats["processing_time"], 3)
                                     ~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'processing_time'
21:47:10 ERROR - Exception during execution 'processing_time': None

When we check for runtime stats like processing_time we need to make sure these attributes actually exists.

This has to be done for both python and ray launchers.

Reproduction script

Code Step 3.2: https://github.com/IBM/data-prep-kit/blob/dev/examples/notebooks/intro/dpk_intro_1_python.ipynb

Anything else

No response

OS

Ubuntu

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@sujee sujee added the bug Something isn't working label Nov 5, 2024
@sujee sujee changed the title [Bug] Python launcher error when the process dies [Bug] Python launcher error when the child process dies Nov 5, 2024
@sujee
Copy link
Contributor Author

sujee commented Nov 5, 2024

may be related to #719

@daw3rd daw3rd added the fixed Marks an issues as fixed in the dev branch label Nov 7, 2024
@daw3rd
Copy link
Member

daw3rd commented Nov 7, 2024

I believe this has been address in PR #721 and will be available in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

3 participants