Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Android assets workflows for separate content repos #2109

Closed
esmeetewinkel opened this issue Oct 23, 2023 · 5 comments · Fixed by #2255
Closed

[FEATURE] Android assets workflows for separate content repos #2109

esmeetewinkel opened this issue Oct 23, 2023 · 5 comments · Fixed by #2255
Labels
feature Work on app features/modules

Comments

@esmeetewinkel
Copy link
Collaborator

What?
Revise whether Android asset generation workflows still make sense and work for deployments whose content sits in a stand-alone repo.
@esmeetewinkel esmeetewinkel added the feature Work on app features/modules label Oct 23, 2023
@jfmcquade
Copy link
Collaborator

jfmcquade commented Oct 24, 2023 •
edited
Loading

Additionally, the package we use to generate the Android assets has been deprecated in favour of capacitor-assets (which is CLI only so will need a new adapter)

See #2072.

Would also be good to ensure we're supporting the latest implementation of splash screens if possible, see migration docs for post-Android 12 here.

@esmeetewinkel
Copy link
Collaborator Author

esmeetewinkel commented Oct 24, 2023 •
edited
Loading

Work-around/resolved by putting it into the android build workflow. No means to preview at this stage. Could be done with Appetize.

@esmeetewinkel
Copy link
Collaborator Author

Additionally, the package we use to generate the Android assets has been deprecated in favour of capacitor-assets (which is CLI only so will need a new adapter)

#2072

@esmeetewinkel
Copy link
Collaborator Author

@jfmcquade to mention in documentation that this is part of github action, and then close this issue

@chrismclarke
Copy link
Member

Is this something still required? Not sure if it might be closed alongside work in #2252 @jfmcquade ?

@jfmcquade jfmcquade mentioned this issue Mar 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Work on app features/modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Android config workflows IDEMSInternational/open-app-builder
3 participants
@chrismclarke @jfmcquade @esmeetewinkel