We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What API behavior do we want whe user code calls Node.subscribe with an already subscribed peer id but a new callback?
Node.subscribe
Previous implementation had this:
ids.filter((id) => !this.subscriptions.has(id)) .forEach((id) => { this.subscriptionsManager.subscribe(id, handler) }) .forEach((id) => { this.subscriptionsManager.subscribe(id, handler) })
This appears to ignore a second call to subscribe for the same peer id.
subscribe
The text was updated successfully, but these errors were encountered:
No branches or pull requests
What API behavior do we want whe user code calls
Node.subscribe
with an already subscribed peer id but a new callback?Previous implementation had this:
This appears to ignore a second call to
subscribe
for the same peer id.The text was updated successfully, but these errors were encountered: