Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage code and image optimization #87

Open
MirandaEcho opened this issue Jun 9, 2020 · 11 comments
Open

Homepage code and image optimization #87

MirandaEcho opened this issue Jun 9, 2020 · 11 comments

Comments

@MirandaEcho
Copy link
Collaborator

No description provided.

@MirandaEcho MirandaEcho added this to the MISS-009 Support Retainer milestone Jun 9, 2020
@MirandaEcho
Copy link
Collaborator Author

MirandaEcho commented Jul 14, 2020

@MirandaEcho MirandaEcho changed the title Homepage code and image optimization (pending analysis) Homepage code and image optimization Jul 14, 2020
@benlk benlk self-assigned this Jul 14, 2020
@benlk
Copy link
Collaborator

benlk commented Jul 14, 2020

Replace the JS lazy-loader with the Wordpress feature plugin (<1h) - Implement on staging, check mobile pagespeeds before and after (esp on Safari), and report back

There are potentially two image lazy-loaders in effect here: wp-smush-pro and autoptimize.

Using http://mstoday.staging.wpengine.com/2020/06/15/ihl-college-board-to-approve-relocating-confederate-monument-from-heart-of-ole-miss-campus/ as an example, here's Chrome's Lighthouse report:

Screen Shot 2020-07-14 at 18 29 40

And Safari's "Timelines" audit, which isn't anywhere near as featureful as Chrome:

Screen Shot 2020-07-14 at 18 35 00

Steps taken:

  • disabled Autoptimize's lazy-loader and CDN

Afterwards, Chrome and Safari:

Screen Shot 2020-07-14 at 18 38 58

Screen Shot 2020-07-14 at 18 39 45


Nevermind, then. This looks like a performance detriment.

@benlk
Copy link
Collaborator

benlk commented Jul 14, 2020

Research ways to display most recent tweets (3) in a less resource-intensive way than the current embedded feed (30min)

Twitter's own widget generator does not offer this option, at https://publish.twitter.com/?dnt=1&query=https%3A%2F%2Ftwitter.com%2FMSTODAYnews&widget=Timeline

Options:

  • Not embed a Twitter widget. The solution for fast-moving Tweet-based coverage of breaking stories would then be to render a single tweet in a widget when editors want to push breaking news — I've set up a demonstration in a Text Widget in the "Main Sidebar" widget area on http://mstoday.staging.wpengine.com/
  • Use a third-party WordPress plugin that fetches, caches, and displays MS Today's feed.

benlk added a commit that referenced this issue Jul 15, 2020
Homepage top image goes from 1170px wide to 771px wide
its maximum displayed width is 646px at 680px viewport width

Homepage featured images go from 800px 4:3 to 400px 4:3
their maximum displayed width is 246px at above 1170px viewport width

For #87, based on
research in #86
@MirandaEcho
Copy link
Collaborator Author

Can we do some quick research with the remaining time to see if there's a plugin that would work for this?

@joshdarby
Copy link

joshdarby commented Jul 16, 2020

@MirandaEcho A few options for Twitter:

@MirandaEcho
Copy link
Collaborator Author

Great, let's give that first one a shot on staging. We can wait until we do the other deploys first though, so:

  1. Get a benchmark pagespeed after the other updates
  2. Replace the twitter feed
  3. Test pagespeed again.

@joshdarby
Copy link

joshdarby commented Jul 16, 2020

@MirandaEcho We'll need to ask Lauchlin to provide us with these 4 keys in order to configure the Twitter plugin:

  • Consumer key
  • Consumer secret
  • Access token
  • Access token secret

@MirandaEcho
Copy link
Collaborator Author

@joshdarby Lauchlin wasn't able to find those in her twitter account, but she sent the creds and they're in 1Pass so we can grab the needed keys ourselves.

@joshdarby
Copy link

@MirandaEcho The twitter widget is now enabled at http://mstoday.staging.wpengine.com/

@MirandaEcho
Copy link
Collaborator Author

Thanks @joshdarby! Are we able to tell if it does better performance-wise?

@joshdarby
Copy link

@MirandaEcho The prod site has a score of 2/100 while the staging site now has a score of 22/100. However, staging doesn't have all of the caching and whatnot that prod does, so it's kind of hard to get a full scope of what the performance increase will be.

However, lighthouse isn't complaining about the new twitter widget, which is a good sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants