-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Text WYSIWYG Editor - Design System #529
Open
g-saracca
wants to merge
12
commits into
develop
Choose a base branch
from
feat/525-rich-text-editor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
A percentage of a sprint. 2.1 hours.
D: Design System
Deliverable: Design System
GREI Re-arch
GREI re-architecture-related
Original size: 3
SPA.Q4
Not related to any specific Q4 feature
FY25 Sprint 9
FY25 Sprint 9 (2024-10-23 - 2024-11-06)
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
D: Design System
Deliverable: Design System
FY25 Sprint 9
FY25 Sprint 9 (2024-10-23 - 2024-11-06)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q4
Not related to any specific Q4 feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new Rich Text Editor component to the design system.
This component is made with Tiptap npm packages.
Tiptap is a headless wrapper around ProseMirror – a toolkit for building rich text WYSIWYG editors, which is already in use at many well-known companies such as New York Times, The Guardian or Atlassian.
Cons: It does not support markdown as output, the output is html.
Pros:
Which issue(s) this PR closes:
Suggestions on how to test this:
Visual code inspection and Storybook story manual testing.
The component has 100% unit test coverage as well.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: