Base64 Icons are extremely lengthy #362
Unanswered
kohasummons
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Often times we get PRs that contribute to our growing stash of badges. While we appreciate these contributions - and contributors, there is a sinister issue that has been leaking into some of these contributions - base64 logos make the URL extremely long.
A little background, markdown-badges leverage the @shields.io API. The shields API utilizes the simple icons project to provide icons for badges. For quite a while these have worked quite well until there was a need for badges which simple icon has no icons in its stash for. Hence, we leverage the shields.io option to use a base64 encoding to represent the icons. Here's an example of what that should look like #342
The badge:
The URL that cooked the badge:
Yes, it does render the badge well yet imagine a bunch of these crawling around in our repo. Would be quite messy and the risk for errors would exponentially rise. As it stands right now, this is the way to offer icons not provided by simple icons.
How best should we handle this?
Beta Was this translation helpful? Give feedback.
All reactions