Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ParametricMap to use new VOILUTTransformation class #168

Open
CPBridge opened this issue Apr 22, 2022 · 1 comment
Open

Change ParametricMap to use new VOILUTTransformation class #168

CPBridge opened this issue Apr 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@CPBridge
Copy link
Collaborator

Unify the API of the ParametricMap class with the presentation state SOPClasses by having the user provide a VOILUTTransformation object to the constructor. This is a backward incompatible change
@CPBridge CPBridge added the enhancement New feature or request label Apr 22, 2022
@hackermd
Copy link
Collaborator

What do you think about adding thevoi_lut_transformation: Optional[VOILUTTransformation] parameter and including a deprecation warning for window_width and window_center? That would make it easier to deprecate the parameters in a future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackermd @CPBridge