Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Composite Instance shall contain the Contributing Equipment Sequence (0018,A001). #94

Open
malaterre opened this issue Jul 28, 2021 · 1 comment
Labels
invalid This doesn't seem right

Comments

@malaterre
Copy link
Contributor

I believe some part of the standard have not yet been implemented in the classic to enhanced conversion step:

The new Composite Instance shall contain the Contributing Equipment Sequence (0018,A001). If the source Composite Instances already contain the Contributing Equipment Sequence with a consistent set of Item values (excluding Contribution DateTime (0018,A002)), then a new Item shall be appended to the copy of the sequence in the new Composite Instance; if the source Composite Instance does not contain the Contributing Equipment Sequence or the Item values (excluding Contribution DateTime (0018,A002)) differ between source instances, then Contributing Equipment Sequence shall be created, containing one new Item. In either case, the new Item shall describe the equipment that is creating the new Composite Instance, and the Purpose of Reference Code Sequence (0040,A170) within the Item shall be (109106, DCM, "Enhanced Multi-frame Conversion Equipment") and the Contribution Description (0018,A003) shall be "Legacy Enhanced Image created from Classic Images", "Classic Image created from Enhanced Image", or "Updated UID references during Legacy Enhanced Classic conversion" as appropriate.

@CPBridge
Copy link
Collaborator

Hi @malaterre, thanks a lot for reporting this issue.

Unfortunately the Legacy Conversion part of the library has not got much love recently. There are known shortcomings and a long-standing PR (#34) that should greatly improve this part of the library, kindly contributed by @afshinmessiah, but it needs a little work from the core developers and we have unfortunately had other priorities over the last couple of months.

It looks like #34 should address the specific point you raise here. I will leave this issue open so that we can revisit after #34 is merged

@CPBridge CPBridge added the invalid This doesn't seem right label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants