Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Notification Toast will be displayed on clicking "Integrate with github" #2785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mhammad-riyaz
Copy link

Description 📣

Fixes 2783
Fixes the bug where the "Integrate with GitHub" button in the Secret Scanning tab failed silently.
Added a user feedback toast message to inform users of failures.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

    const generateNewIntegrationSession = async () => {
      const session = await createNewIntegrationSession(String(localStorage.getItem("orgData.id")));
      if(session){
        router.push(
          `https://github.com/apps/infisical-radar/installations/new?state=${session.sessionId}`
        );
      }else{
        createNotification({text : "Secret scanning is temporarily unavailable.",type:"error"});
      }
    };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret Scanning: 'Integrate with GitHub' Button Fails Without User Feedback
1 participant