Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Scanning: 'Integrate with GitHub' Button Fails Without User Feedback #2783

Open
Mhammad-riyaz opened this issue Nov 24, 2024 · 0 comments · May be fixed by #2785
Open

Secret Scanning: 'Integrate with GitHub' Button Fails Without User Feedback #2783

Mhammad-riyaz opened this issue Nov 24, 2024 · 0 comments · May be fixed by #2785

Comments

@Mhammad-riyaz
Copy link

Describe the bug

In the secret scanning tab, the "Integrate with Github" button is not working.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the Secret Scanning tab.
  2. Click on the "Integrate with GitHub" button.
  3. Observe that no toast or actionable feedback is provided, and the integration does not proceed.

Expected behavior

Clicking on the "Integrate with GitHub" button should:
Provide user feedback, such as a toast or notification, indicating the status of the integration.

Screenshots

image
image

Additional context

Clicking the button triggers the createNewIntegrationSession function.
This function sends a request to the backend endpoint registerSecretScanningRouter.
The backend checks if the organization ID is listed in SECRET_SCANNING_ORG_WHITELIST.
If the ID is not whitelisted, the backend returns a 400 Bad Request with a message saying that Secret scanning is temporarily unavailable.
As a result, createNewIntegrationSession returns undefined, causing the error.
No feedback is provided to the user regarding this failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant