Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-time tags for pipelines images and service descriptors #25

Open
alanbchristie opened this issue Nov 14, 2018 · 1 comment
Open

Comments

@alanbchristie
Copy link
Collaborator

In OpenShift (and Docker), if an existing pipelines image has been deployed re-running the poster image adds the modified or new service descriptors but the underlying image is not necessarily re-pulled.

To solve the problem in OpenShift the imagePullPolicy could be set to Always but this would introduce significant execution delays, especially as pipeline image layers can be substantial.

Anther idea is to use explicit tags on the service descriptor's image reference (the imageName property). And, more importantly, set these at build time. We could have a tag formed from a short-form of the build date. If we expected to produce just one official copy of the pipeline each day the image tag could be 2018-11-14. We set that in the service descriptor imageName value as it's written to the poster image. Finally, we push the corresponding pipelines image using the same tag.

@alanbchristie
Copy link
Collaborator Author

ServiceDiscoveryRouteBuilder now processes headers, specifically: -

  • Image-Pull-Secret
  • Image-Registry
  • Image-Tag

So, if we use the prevailing TRAVIS_TAG as the Image-Tag then we can version pipelines within the execution environment. The service descriptor container image simply needs a copy of the TRAVIS_TAG (for tagged builds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant