Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement isSigned #593

Open
Soupstraw opened this issue Oct 10, 2024 · 2 comments
Open

Properly implement isSigned #593

Soupstraw opened this issue Oct 10, 2024 · 2 comments

Comments

@Soupstraw
Copy link
Contributor

Soupstraw commented Oct 10, 2024

At the moment it uses a dummy implementation. We need an implementation that actually checks the signature.

@jmchapman
Copy link

  • need more info
  • a decision how to implement it
  • an estimate

@TimSheard
Copy link

TimSheard commented Oct 22, 2024

I think this may be talking about finding witnesses for Keys and Script hashes in a transaction body.
Currently we randomly generate things that look like hashes, but finding the Key or Script that hashes
to that hash is impossible. We will have to randomly generate an universe of pairs (Map Hash KeyPair, Map Hash Script) and then pick hashes from this universe. Then we can figure out how to sign by using this universe.
Of course I could be wrong.

@MaximilianAlgehed and I talked about this today as something we will need to do for conformance testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants