Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer want to improve version and changelog workflow #81

Open
Ismoh opened this issue Oct 6, 2022 · 6 comments
Open

Developer want to improve version and changelog workflow #81

Ismoh opened this issue Oct 6, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code
Milestone

Comments

@Ismoh
Copy link
Owner

Ismoh commented Oct 6, 2022

When a pull request is merged to develop, version will be increased and changelog will be updated.
Problem on this: Each PR will in crease version and changelog of one version only contains one PR.
Simply looks and feels wrong.
This has to be done on master, but on master the version increase won't work out of the box, because the workflow atm isn't able to fetch all PRs labels.

To fix that, it might be a solution to simply keep the version updated/bumped, when a PR is merged into develop, but it won't update the changelog nor create a tag.

When merging in master, create always a tag and a new changelog.

This will be done, when actionsbot checks comments for Create a tag.
A new release will be created, when develop was merged into master. For this release stuff a new workflow has to be created:

  • increase version
  • update changelog
  • check for comment Create release
  • copy mods\noita-mp content
  • add changelog.md to this content
  • create artifact
  • create a GitHub release
  • put changelog.md content into release description body
@Ismoh Ismoh added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Oct 6, 2022
@Ismoh Ismoh added this to the Nice-to-have on GitHub milestone Oct 6, 2022
@Ismoh Ismoh self-assigned this Oct 8, 2022
@Ismoh
Copy link
Owner Author

Ismoh commented Oct 14, 2022

Additional problem occurs:
HarshCasper/validate-issues-over-pull-requests#3

@Ismoh
Copy link
Owner Author

Ismoh commented Oct 28, 2022

first good issue and help wanted are broken, when workflow bot copies labels from issue to pull request due to spaces in label names, see #85 (comment)

@Ismoh Ismoh added this to NoitaMP Nov 22, 2022
@Ismoh Ismoh moved this to 📋 Backlog in NoitaMP Nov 22, 2022
@Ismoh
Copy link
Owner Author

Ismoh commented Jan 16, 2023

Use Ismoh-Games/find-linked-issues for this
Or
Implement a new GitHub action workflow

@Ismoh
Copy link
Owner Author

Ismoh commented Feb 17, 2023

Commit and push changes is source branch and not in target branch!
When changed, add branch protections again to master and develop!

@Ismoh
Copy link
Owner Author

Ismoh commented Jun 27, 2023

@Ismoh
Copy link
Owner Author

Ismoh commented Oct 1, 2023

Do this before creating a public release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code
Projects
Status: 📋 Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant