Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer want to improve minäs death #87

Open
Ismoh opened this issue Oct 30, 2022 · 5 comments
Open

Developer want to improve minäs death #87

Ismoh opened this issue Oct 30, 2022 · 5 comments
Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop. good_first_issue Good for newcomers help_wanted Extra attention is needed

Comments

@Ismoh
Copy link
Owner

Ismoh commented Oct 30, 2022

Is your feature request related to a problem? Please describe.
After Minä died, client has to reconnect and server has to restart server. Game is more or less over, although remote Minä is still alive.

Describe the solution you'd like
There has to be a revive or respawn function:
Remote Minä coule revive dead ones, but you have to wait until a alive Minä stands still next to you. After revive Minä has x HP.

Describe alternatives you've considered
Second and additional approach could be, that all dead Minäs will be respawn with 1hp in the next holy mountain, when one of the still alive Minäs jumped into HM.

Additional context
Check if Minä is in holy mountain: https://discord.com/channels/453998283174576133/632303734877192192/1031232571050315816
Change Minäs death:
https://discord.com/channels/453998283174576133/632303734877192192/972256748205391903

@Ismoh Ismoh added enhancement New feature or request. This will increase MINOR version number, when merged into develop. help_wanted Extra attention is needed good_first_issue Good for newcomers labels Oct 30, 2022
@Ismoh Ismoh added this to the Features or QoL milestone Oct 30, 2022
@Ismoh
Copy link
Owner Author

Ismoh commented Nov 22, 2022

Branch based on #48
@SiriMoel is interested in doing this

@Ismoh Ismoh added this to NoitaMP Nov 22, 2022
@Ismoh Ismoh moved this to 📋 Backlog in NoitaMP Nov 22, 2022
@Ismoh
Copy link
Owner Author

Ismoh commented Dec 23, 2022

When Minä dies of local client or server, remove camera component or however this thingy is called. It's a component to let the camera know who and which to follow.
But make sure that there are other minäs, otherwise the run will never end.

@Ismoh Ismoh moved this from 📋 Backlog to 🏗 In progress in NoitaMP Jan 8, 2023
@Ismoh
Copy link
Owner Author

Ismoh commented Jan 8, 2023

@Conga0 is working on this. Thanks a ton!

@Ismoh
Copy link
Owner Author

Ismoh commented Jan 9, 2023

Based on this

yes, you can set DamageModelComponent:wait_for_kill_flag_on_death="1" so the entity doesn't die
player.xml and player_base.xml has to be changed. Need to double check namings.
The other coding unfortunatelly needs to be added in NoitaComponents:
https://github.com/Ismoh/NoitaMP/tree/87-developer-want-to-improve-min%C3%A4s-death/mods/noita-mp/files/scripts/noita-components
This new component has to be added to minäs entities.
Then globals has to be set, like 'isDead'.
Then init.lua has to check for this global and send networkMessages

@Ismoh
Copy link
Owner Author

Ismoh commented Jan 10, 2023

Might be worth it to investigate time for being able to sync components data.
Not quite sure atm, how to implement this on a performance good way, but needs to be implemented, otherwise components like VSCs aren't updated on each peer.

Conga0 added a commit to Conga0/NoitaMP that referenced this issue Jan 10, 2023
Conga0 added a commit to Conga0/NoitaMP that referenced this issue Jan 10, 2023
…ew file to check if alive minas are nearby revive-check-nearby.lua
Conga0 added a commit to Conga0/NoitaMP that referenced this issue Feb 12, 2023
Conga0 added a commit to Conga0/NoitaMP that referenced this issue Feb 12, 2023
@Ismoh Ismoh moved this from 🏗 In progress to 📋 Backlog in NoitaMP Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop. good_first_issue Good for newcomers help_wanted Extra attention is needed
Projects
Status: 📋 Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant