Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-pr-contains-action fails on big diffs? #133

Open
Cellcote opened this issue Apr 19, 2024 · 1 comment
Open

github-pr-contains-action fails on big diffs? #133

Cellcote opened this issue Apr 19, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@Cellcote
Copy link

Cellcote commented Apr 19, 2024

We have been using this github action for a while and seems to be working fine for us with no real problems. Now I tried doing a refactor on the whole code base (~500 files touched, 34k lines of code), and the whole github action just does not work. The error we get is this:

Checking body contents
Checking diff contents
Getting diff for: <org>, <repo>, <pr number>
Error: ❌ There seems to be an error in an API request
This is usually due to using a GitHub token without the adequate scope

In other PRs, it works just fine, and also retries did not help.

Our config is like this:

steps:
      - uses: JJ/github-pr-contains-action@releases/v12.1
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          bodyDoesNotContain: "escribe the *\\*_what_\\*\\* and \\*\\*_why_\\*\\* of the change"

so ideally it should only scan the body (nothing crazy there) and skip scanning the diff if the config only specifies restrictions on the body of the PR.

@JJ
Copy link
Owner

JJ commented Apr 19, 2024

Definitely needs a revision. Thanks for the report!

@JJ JJ added the bug Something isn't working label Apr 19, 2024
@JJ JJ added this to the v15 milestone Apr 19, 2024
JJ added a commit that referenced this issue Apr 19, 2024
JJ added a commit that referenced this issue Apr 19, 2024
@JJ JJ mentioned this issue Apr 19, 2024
1 task
JJ added a commit that referenced this issue Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants