dbReadProfile finds filters by matching on filter.id in the database, but dbAddRuleFilter stores the ruleId in filter.rule

[frereit]

When using --import-data (and possible other code paths leading to dbAddRuleFilter), the rule id this filter belongs to is stored in the rule field of the filter table:

ical-relay/pkg/datastore/database.go

Lines 445 to 447 in ea4ce94

	_, err = db.Exec(
	`INSERT INTO filter (rule, type, parameters) VALUES ($1, $2, $3) RETURNING id`,
	ruleId, filterType, parametersJson)

However, when retrieving a rule, only filters where the id of the filter in the database matches the rule are returned:

ical-relay/pkg/datastore/database.go

Lines 205 to 206 in ea4ce94

	var dbFilters []dbFilter
	err = db.Select(&dbFilters, "SELECT type, parameters FROM filter WHERE id = $1", dbRule.Id)

This mismatch causes at least --import-data to fail. Simply changing the SELECT statement to match on rule = $1 instead works, but I'm unsure if this doesn't break other parts of the codebase which store the rule id in the id field of filter.