Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making PassVerifier generic over the credential type #8

Open
JedS6391 opened this issue Nov 16, 2021 · 0 comments
Open

Consider making PassVerifier generic over the credential type #8

JedS6391 opened this issue Nov 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@JedS6391
Copy link
Owner

JedS6391 commented Nov 16, 2021

Currently the library is limited to the PublicCovidPass credential type, but it may be worthwhile making this more flexible.

A possible signature for the verifier could be:

// Verifies the provided payload as a pass of type `TCredential`
Task<PassVerifierContext<TCredential>> VerifyAsync<TCredential>(string passPayload);

Most of the components are already designed to be agnostic to the type of pass - the main touch points would be:

  • CwtSecurityToken: need a way to expose a generic pass
  • PassVerifier: need a way to accept the credential type and pass it through to the relevant components
@JedS6391 JedS6391 added the enhancement New feature or request label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant