Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smart pointers instead of bare pointers. #15

Open
pbutti opened this issue Oct 24, 2019 · 2 comments
Open

Use smart pointers instead of bare pointers. #15

pbutti opened this issue Oct 24, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@pbutti
Copy link
Collaborator

pbutti commented Oct 24, 2019

Update the code to use smart pointers instead of bare pointers
@pbutti pbutti added the enhancement New feature or request label Oct 24, 2019
@mholtrop
Copy link
Collaborator

Related would be to move consistently to "vector< Whatever *>" instead of TClonesArray *Whatever, and have the pointers that go into the vector<> protected by std::unique_ptr.

I think it would be good to get consistent with this before too much code depends on this choice.

@pbutti
Copy link
Collaborator Author

pbutti commented Oct 31, 2019

Hi Maurik,

Ok. I'll harmonise the code before the end of the week

pbutti pushed a commit to pbutti/hpstr that referenced this issue Nov 15, 2019
@omar-moreno
Merge pull request JeffersonLab#15 from omar-moreno/iss14
3ef26a6 
Grants access to Tree during initialization stage.
cbravo135 pushed a commit to cbravo135/hpstr that referenced this issue Jan 24, 2020
@omar-moreno
Merge pull request JeffersonLab#15 from omar-moreno/iss14
3046544 
Grants access to Tree during initialization stage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mholtrop @pbutti