Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload of equality comparison (:==) fails with Julia 1.6 #3

Open
dm3 opened this issue May 17, 2021 · 0 comments
Open

Overload of equality comparison (:==) fails with Julia 1.6 #3

dm3 opened this issue May 17, 2021 · 0 comments

Comments

@dm3
Copy link

dm3 commented May 17, 2021

Running tests on 1.6 gives the following error:

MethodError: ==(::CompoundPeriod, ::CompoundPeriod) is ambiguous. Candidates:
    ==(x::P1, y::P2) where {P1<:CompoundPeriod, P2<:CompoundPeriod} in CompoundPeriods at /home/travis/build/JeffreySarnoff/CompoundPeriods.jl/src/compare.jl:1
    ==(x::CompoundPeriod, y::CompoundPeriod) in Dates at /home/travis/julia/share/julia/stdlib/v1.6/Dates/src/periods.jl:366

I guess the overload was required for pre-1.6 Julia. If so, we should conditionally exclude the overload for 1.6+, is this right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dm3